Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 7b control models #767

Closed
wants to merge 1 commit into from

Conversation

MartinAchtnerAA
Copy link

@MartinAchtnerAA MartinAchtnerAA commented Apr 22, 2024

Description

We would like to use these models for safety classification in F13.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@MartinAchtnerAA MartinAchtnerAA force-pushed the F13-114-new-luminous-models branch from a6ef64f to 78b8168 Compare April 22, 2024 08:15
@NiklasKoehneckeAA
Copy link
Contributor

It's missing a changelog entry. I assume the new control models have the same prompt layout as the old ones?

@MartinAchtnerAA MartinAchtnerAA force-pushed the F13-114-new-luminous-models branch from 78b8168 to fcfe7e1 Compare April 22, 2024 08:36
@MartinAchtnerAA MartinAchtnerAA force-pushed the F13-114-new-luminous-models branch from fcfe7e1 to 751415d Compare April 22, 2024 08:39
@NiklasKoehneckeAA
Copy link
Contributor

After consulting with @NickyHavoc, we came to the conclusion that this should not yet be in the Intelligence Layer. The prompt layout for the new models is not yet final and customers do not have access to these models yet. This necessitates a type ignore if you use these new models in your code tho. We may need to think about a solution for this

@NiklasKoehneckeAA NiklasKoehneckeAA deleted the F13-114-new-luminous-models branch April 30, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants